feat(builder): allow for multiple private keys #725
Merged
+61
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancoombs
requested review from
dphilipson,
0xfourzerofour and
alex-miao
as code owners
0xfourzerofour
approved these changes
Jun 14, 2024
dphilipson
approved these changes
Jun 17, 2024
dancoombs
force-pushed
the
danc/conditional-errors
branch
from
67ed116
to
23afa42
Compare
dancoombs
force-pushed
the
danc/conditional-errors
branch
from
23afa42
to
883c454
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #724
Proposed Changes
builder.private_keysCLI flag. Deprecatebuilder.private_key, combine if both used.